Repository navigation
Add documentation section about linking to other stories and pages from MDX - #14783
Merged
Merged
Conversation
Nx Cloud ReportCI ran the following commands for commit 83c266a. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch
Sent with 💌 from NxCloud. |
jonniebigodes
added
documentation
patch:yes
ndelangen
approved these changes
May 3, 2021
jonniebigodes
requested changes
May 3, 2021
jonniebigodes
left a comment
jonniebigodes
left a comment
Contributor
There was a problem hiding this comment.
@Dschungelabenteuer thank you for the time and effort you put into this pull request. I left one note regarding it. Let me know and we'll go from there.
Stay safe
| [Go to the conclusion of the documentation page](?path=/docs/some--id#conclusion) | ||
| ``` | ||
|
|
||
| Note that when using the Controls addon, anchors are ignored by the Canvas tab since the URL gets rewritten to track the args values. |
Contributor
There was a problem hiding this comment.
@Dschungelabenteuer one thing about this. If you could adjust this to :
<div class="aside">
💡 <strong>Note:</> By applying this pattern with the Controls addon, all anchors will be ignored in Canvas based on how Storybook handles URLs to track the args values.
</divSomething like this. Let me know what you thing?
Contributor
Author
There was a problem hiding this comment.
Much better 👍
shilman
approved these changes
May 5, 2021
shilman
left a comment
shilman
left a comment
Member
There was a problem hiding this comment.
Thanks so much for documenting @Dschungelabenteuer !! We should fix this @ghengeveld ...
shilman
added
the
patch:done
shilman
added a commit
that referenced
this pull request
May 8, 2021
Add documentation section about linking to other stories and pages from MDX
yannbf
removed
the
patch:yes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
As asked on the Discord server by @shilman, I've tried to explain quite briefly how to provide links (and also include anchors) to other stories and content. With a small notice about the anchors being ignored when targeting the "story" view mode (Canvas tab).
Not sure this is clear enough, and whether that video is relevant/useful.
How to test