Skip to content

Chore: (Docs): Minor tweaks for Vue 3 and FAQ updates - #14765

Merged
shilman merged 1 commit into
nextfrom
vue_3_minor_adjustments
Apr 30, 2021
Merged

shilman merged 1 commit into
nextfrom
vue_3_minor_adjustments

Conversation

@jonniebigodes

Copy link
Copy Markdown
Contributor

With this pull request the FAQ, and install instructions for Vue 3 based projects were updated to drop the usage of the pre-release version (6.2).

Also, some work was done on the FAQ section to reflect this change as we were incorrectly mentioning to the users that they need to specifically set the vue3 for Storyshots, when that's not the case. It automatically detected based on a recent test.

Feel free to provide feedback

@jonniebigodes jonniebigodes added documentation patch:yes Bugfix & documentation PR that need to be picked to main branch labels Apr 29, 2021
@nx-cloud

nx-cloud Bot commented Apr 29, 2021 •

Copy link
Copy Markdown

Nx Cloud Report

CI ran the following commands for commit 6adf6ce. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=prepare --all --parallel --max-parallel=15

Sent with 💌 from NxCloud.

@shilman shilman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff @jonniebigodes 🔥

@shilman
shilman merged commit eed2359 into next Apr 30, 2021
@shilman
shilman deleted the vue_3_minor_adjustments branch April 30, 2021 03:12
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label May 8, 2021
shilman added a commit that referenced this pull request May 8, 2021
Chore: (Docs): Minor tweaks for Vue 3 and FAQ updates
@yannbf yannbf removed the patch:yes Bugfix & documentation PR that need to be picked to main branch label Oct 28, 2025
@github-actions

Copy link
Copy Markdown
Contributor
Fails
🚫

Danger failed to run .ci/danger/dangerfile.ts.

Error Error

Command failed: npm install lodash
npm error code ERESOLVE
npm error ERESOLVE unable to resolve dependency tree
npm error
npm error While resolving: @storybook/root@6.3.0-alpha.16
npm error Found: eslint@7.32.0
npm error node_modules/eslint
npm error   dev eslint@"^7.17.0" from the root project
npm error
npm error Could not resolve dependency:
npm error peer eslint@"^6.0.0" from @storybook/linter-config@2.5.0
npm error node_modules/@storybook/linter-config
npm error   dev @storybook/linter-config@"^2.5.0" from the root project
npm error
npm error Fix the upstream dependency conflict, or retry
npm error this command with --force or --legacy-peer-deps
npm error to accept an incorrect (and potentially broken) dependency resolution.
npm error
npm error
npm error For a full report see:
npm error /github/home/.npm/_logs/2025-10-28T13_43_48_447Z-eresolve-report.txt
npm error A complete log of this run can be found in: /github/home/.npm/_logs/2025-10-28T13_43_48_447Z-debug-0.log

Error: Command failed: npm install lodash
npm error code ERESOLVE
npm error ERESOLVE unable to resolve dependency tree
npm error
npm error While resolving: @storybook/root@6.3.0-alpha.16
npm error Found: eslint@7.32.0
npm error node_modules/eslint
npm error   dev eslint@"^7.17.0" from the root project
npm error
npm error Could not resolve dependency:
npm error peer eslint@"^6.0.0" from @storybook/linter-config@2.5.0
npm error node_modules/@storybook/linter-config
npm error   dev @storybook/linter-config@"^2.5.0" from the root project
npm error
npm error Fix the upstream dependency conflict, or retry
npm error this command with --force or --legacy-peer-deps
npm error to accept an incorrect (and potentially broken) dependency resolution.
npm error
npm error
npm error For a full report see:
npm error /github/home/.npm/_logs/2025-10-28T13_43_48_447Z-eresolve-report.txt
npm error A complete log of this run can be found in: /github/home/.npm/_logs/2025-10-28T13_43_48_447Z-debug-0.log

    at genericNodeError (node:internal/errors:984:15)
    at wrappedFn (node:internal/errors:538:14)
    at checkExecSyncError (node:child_process:891:11)
    at execSync (node:child_process:963:15)
    at Object.<anonymous> (.ci/danger/dangerfile.ts:5:30)
    at Module._compile (node:internal/modules/cjs/loader:1521:14)
    at requireFromString (/usr/src/danger/node_modules/require-from-string/index.js:28:4)
    at /usr/src/danger/dist/runner/runners/inline.js:183:68
    at step (/usr/src/danger/dist/runner/runners/inline.js:56:23)
    at Object.next (/usr/src/danger/dist/runner/runners/inline.js:37:53)

Dangerfile

------------------^

Generated by 🚫 dangerJS against 6adf6ce

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation patch:done Patch/release PRs already cherry-picked to main/release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants