Skip to content

(Documentation) add unsupported addon Icon format - #14705

Merged
shilman merged 1 commit into
nextfrom
doc_svg_addon_icon
Apr 23, 2021
Merged

shilman merged 1 commit into
nextfrom
doc_svg_addon_icon

Conversation

@frassinier

Copy link
Copy Markdown
Contributor

What I did

SVG are not supported for SB addon Icon, add a quick note about it.

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

SVG are not supported for SB addon Icon, add a quick note about it.

@shilman shilman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thanks @frassinier !

@shilman shilman added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Apr 23, 2021
@shilman
shilman merged commit 643e7eb into next Apr 23, 2021
@shilman
shilman deleted the doc_svg_addon_icon branch April 23, 2021 14:52
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label May 8, 2021
shilman added a commit that referenced this pull request May 8, 2021
(Documentation) add unsupported addon Icon format
@ndelangen ndelangen removed the patch:yes Bugfix & documentation PR that need to be picked to main branch label Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation patch:done Patch/release PRs already cherry-picked to main/release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants