Repository navigation
Mention selectors requirement in Angular stories - #14228
Merged
Merged
Conversation
The asterisks on the `entryComponent` approach is kind of making me wonder if we should just give a better console warning if no component selector is provided. In our project, we will probably end up adding the selectors since it's the same amount of changes as `entryComponent` and will work more completely (with inputs).
Member
|
@ThibaudAV does it look good to you? Also, @jonniebigodes do you want to take a quick look as it's somehow related to documentation? |
Nx Cloud ReportCI ran the following commands for commit 05a9815. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch
Sent with 💌 from NxCloud. |
Contributor
|
Yeah, LGTM 🚀 |
ThibaudAV
approved these changes
May 12, 2021
shilman
added
the
patch:yes
shilman
added
the
patch:done
shilman
added a commit
that referenced
this pull request
May 25, 2021
Mention selectors requirement in Angular stories
yannbf
removed
the
patch:yes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migration documentation update to communicate that some changes may be needed for Angular Stories. As discussed here
The asterisks on the
entryComponentapproach is kind of making me wonder if we should just give a better console warning if no component selector is provided. In our project, we will probably end up adding the selectors since it's the same amount of changes asentryComponentand will work more completely (with inputs).