Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Generate version file with preval macro #13715

Merged
merged 4 commits into from
Feb 2, 2021

Conversation

phated
Copy link
Contributor

@phated phated commented Jan 23, 2021

Issue: #11220

What I did

I split out the preval macro code into its own commit from #11220. Couple open questions:

  1. Why does the e2e PnP tests fail?
  2. Does compilation use the babel cache? If so, then How to force recompile? kentcdodds/babel-plugin-preval#19 says we can't use this method.

How to test

  • Is this testable with Jest or Chromatic screenshots? e2e tests seem to catch it
  • Does this need a new example in the kitchen sink apps? ❌
  • Does this need an update to the documentation? ❌

If your answer is yes to any of these, please make sure to include it in your PR.

@phated phated added the maintenance User-facing maintenance tasks label Jan 23, 2021
@gaetanmaisse gaetanmaisse added the run e2e extended test suite Run the e2e extended test suite in CircleCI workflows label Jan 23, 2021
@gaetanmaisse
Copy link
Member

@phated the CI error is:

ERR! Module not found: Error: Can't resolve '../version' in '/tmp/storybook-e2e-testing/react-latest/node_modules/@storybook/api/dist/cjs/modules'
ERR! ModuleNotFoundError: Module not found: Error: Can't resolve '../version' in '/tmp/storybook-e2e-testing/react-latest/node_modules/@storybook/api/dist/cjs/modules'

But it doesn’t seem to be related to Yarn 2 or PnP as all the E2E are failing. You can try to reproduce locally with :
yarn test:e2e-framework react

@phated
Copy link
Contributor Author

phated commented Jan 27, 2021

@gaetanmaisse I just ran that command locally at the react e2e suite passes. Any thoughts on what else I should look into??

@gaetanmaisse
Copy link
Member

🤔 Everything looks ok locally but part of @storybook/api is missing when the package is published in the CI workflow, will investigate a bit by SSHing the CI.

@gaetanmaisse
Copy link
Member

Should be fixed with #13786

@gaetanmaisse gaetanmaisse self-assigned this Feb 2, 2021
@gaetanmaisse gaetanmaisse changed the title Build: generate version file with preval macro Build: Generate version file with preval macro Feb 2, 2021
@gaetanmaisse gaetanmaisse merged commit 32bd615 into storybookjs:next Feb 2, 2021
@phated phated deleted the phated/preval-macro branch February 2, 2021 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks run e2e extended test suite Run the e2e extended test suite in CircleCI workflows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants