Fix bug in storybook common components refactor#1302
Closed
shilman wants to merge 1 commit into
Closed
Conversation
alexandrebodin
approved these changes
Jun 17, 2017
Codecov Report
@@ Coverage Diff @@
## master #1302 +/- ##
=======================================
Coverage 13.76% 13.76%
=======================================
Files 201 201
Lines 4620 4620
Branches 506 582 +76
=======================================
Hits 636 636
+ Misses 3538 3483 -55
- Partials 446 501 +55
Continue to review full report at Codecov.
|
Member
Author
|
Reverting and trying another way |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #1266
What I did
Fixed bug in components refactor. Now
getstorybookneeds to add a@storybook/componentsdependency when it runs, otherwise the components are not found.How to test