Generate template from lib components#1283
Closed
usulpro wants to merge 3 commits into
Closed
Conversation
Codecov Report
@@ Coverage Diff @@
## add-lib-components #1283 +/- ##
======================================================
- Coverage 13.79% 13.75% -0.04%
======================================================
Files 201 202 +1
Lines 4612 4624 +12
Branches 579 512 -67
======================================================
Hits 636 636
- Misses 3475 3548 +73
+ Partials 501 440 -61
Continue to review full report at Codecov.
|
3 tasks
Collaborator
Generated by 🚫 dangerJS |
Member
|
I agree with @ndelangen's approach I think: #1266 (comment) |
f15a548 to
436767d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #1266 (comment)
getstroybook should provide the simplest and hackable code sample
What I did
I take the same
jsfiles fromsrcand put them into thedistwithout babel compilation. Then getstorybook uses them with templates. So we'll have the source code of these components in our project aftergetstorybook. (Same behavior for users, but with the only source of code)How to test