Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update old namespace link and incorrect UI link #1271

Merged
merged 2 commits into from
Jun 14, 2017

Conversation

aaronranard
Copy link
Contributor

Issue:
I noticed the npm link command is out of date in the contribution guide and updated it to what I believe it should be, as well as a link to the Storybook UI page.

What I did

Went through the process of linking the storybook source code locally based on the contribution guide and fixed the out of date docs

How to test

I noticed the npm link command is out of date in the contribution guide and updated it to what I believe it should be, as well as a link to the Storybook UI page.
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM!

@shilman shilman added the cleanup Minor cleanup style change that won't show up in release changelog label Jun 13, 2017
@shilman
Copy link
Member

shilman commented Jun 13, 2017

@orta Travis build is failing due to DANGER_GITHUB_API_TOKEN environment variable being stripped for PR's issued from forked repos:

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#Pull-Requests-and-Security-Restrictions

Have you ever seen this, and do you have a workaround?

@codecov
Copy link

codecov bot commented Jun 14, 2017

Codecov Report

Merging #1271 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1271   +/-   ##
=======================================
  Coverage   13.73%   13.73%           
=======================================
  Files         207      207           
  Lines        4638     4638           
  Branches      519      574   +55     
=======================================
  Hits          637      637           
+ Misses       3552     3510   -42     
- Partials      449      491   +42
Impacted Files Coverage Δ
addons/knobs/src/components/PropField.js 10.86% <0%> (ø) ⬆️
app/react/src/client/preview/error_display.js 0% <0%> (ø) ⬆️
app/react/src/server/babel_config.js 44.82% <0%> (ø) ⬆️
addons/info/src/components/Props.js 0% <0%> (ø) ⬆️
addons/knobs/src/components/types/Boolean.js 11.62% <0%> (ø) ⬆️
lib/ui/src/modules/ui/configs/init_panels.js 25% <0%> (ø) ⬆️
addons/knobs/src/KnobStore.js 6.81% <0%> (ø) ⬆️
addons/info/src/components/PropTable.js 0% <0%> (ø) ⬆️
app/react-native/src/bin/storybook-start.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/api/actions/api.js 49.42% <0%> (ø) ⬆️
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61a3f80...a7078fd. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Minor cleanup style change that won't show up in release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants