Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change file name to add links #1230

Closed
wants to merge 2 commits into from
Closed

Conversation

zobroj
Copy link

@zobroj zobroj commented Jun 9, 2017

I tried adding a tag to my storybook and it didn't work according to old instructions. So I referenced a few projects and it seems that it has changed, i.e. https://github.com/bufferapp/buffer-components/blob/master/.storybook/head.html

Issue:

What I did

How to test

zobroj and others added 2 commits June 9, 2017 13:18
I tried adding a <link> tag to my storybook and it didn't work according to old instructions. So I referenced a few projects and it seems that it has changed, i.e. https://github.com/bufferapp/buffer-components/blob/master/.storybook/head.html
@codecov
Copy link

codecov bot commented Jun 9, 2017

Codecov Report

Merging #1230 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1230   +/-   ##
=======================================
  Coverage   13.72%   13.72%           
=======================================
  Files         207      207           
  Lines        4640     4640           
  Branches      508      514    +6     
=======================================
  Hits          637      637           
+ Misses       3569     3543   -26     
- Partials      434      460   +26
Impacted Files Coverage Δ
addons/knobs/src/KnobStore.js 6.81% <0%> (ø) ⬆️
addons/info/src/components/markdown/code.js 0% <0%> (ø) ⬆️
app/react/src/client/preview/init.js 0% <0%> (ø) ⬆️
addons/knobs/src/components/types/Select.js 7.93% <0%> (ø) ⬆️
lib/ui/src/modules/ui/configs/handle_keyevents.js 33.33% <0%> (ø) ⬆️
addons/info/src/components/PropVal.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/ui/configs/init_panels.js 25% <0%> (ø) ⬆️
lib/ui/src/modules/ui/containers/layout.js 12.5% <0%> (ø) ⬆️
lib/ui/src/modules/ui/configs/handle_routing.js 28.94% <0%> (ø) ⬆️
app/react/src/server/iframe.html.js 0% <0%> (ø) ⬆️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0dbffd...9c20fa6. Read the comment docs.

@shilman
Copy link
Member

shilman commented Jun 9, 2017

@VonIobro preview-head.html is a change that was merged yesterday and hasn't been released yet.

See here: #1134

So while your change is technically correct, it won't be as soon as we do the next release. I'm going to release in the next hour so that the live docs are consistent with the latest released version. I apologize to you for the confusion and hassle here. 😢

@ndelangen @tmeasday we need to figure out a better solution here. See: #1231

@shilman
Copy link
Member

shilman commented Jun 9, 2017

@VonIobro closing this per my description above. thanks for being proactive on the fix and sorry for the trouble. Please let me know if I got something wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants