Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typo in react-native browser instructions #1189

Merged
merged 2 commits into from
Jun 5, 2017
Merged

Conversation

shilman
Copy link
Member

@shilman shilman commented Jun 5, 2017

Issue: N/A

What I did

Minor typo

How to test

Did not test. Followed instructions from README.md and also from https://facebook.github.io/react-native/docs/getting-started.html

@codecov
Copy link

codecov bot commented Jun 5, 2017

Codecov Report

Merging #1189 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #1189    +/-   ##
========================================
  Coverage   13.31%   13.31%            
========================================
  Files         199      199            
  Lines        4589     4589            
  Branches      541      643   +102     
========================================
  Hits          611      611            
+ Misses       3492     3415    -77     
- Partials      486      563    +77
Impacted Files Coverage Δ
...react-native/src/manager/components/PreviewHelp.js 0% <0%> (ø) ⬆️
.../ui/src/modules/ui/components/layout/dimensions.js 15.62% <0%> (ø) ⬆️
addons/knobs/src/components/types/Select.js 7.14% <0%> (ø) ⬆️
app/react/src/server/iframe.html.js 0% <0%> (ø) ⬆️
addons/info/src/components/Props.js 0% <0%> (ø) ⬆️
app/react/src/client/preview/render.js 0% <0%> (ø) ⬆️
addons/knobs/src/components/PropField.js 10.41% <0%> (ø) ⬆️
addons/knobs/src/KnobStore.js 6.81% <0%> (ø) ⬆️
app/react/src/client/preview/client_api.js 39.28% <0%> (ø) ⬆️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6c40e5...233b3d6. Read the comment docs.

Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shilman shilman merged commit 1a247cd into master Jun 5, 2017
@shilman shilman deleted the shilman-patch-1 branch June 5, 2017 11:58
@ndelangen ndelangen added the cleanup Minor cleanup style change that won't show up in release changelog label Jun 7, 2017
@ndelangen ndelangen added this to the v3.0.2 milestone Jun 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Minor cleanup style change that won't show up in release changelog documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants