-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addon-controls: Expose presetColors
for the color control
#11606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
of `addon:controls`.
… PR, and should belong to another PR that changes this behavior for all control components.
shilman
approved these changes
Jul 19, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Will test and merge later today. 🎉🎉🎉
shilman
changed the title
Expose
Addon-controls: Expose Jul 19, 2020
SketchPickerProps.presetColors
for the color control componentpresetColors
for the color control component
shilman
changed the title
Addon-controls: Expose
Addon-controls: Expose Jul 19, 2020
presetColors
for the color control componentpresetColors
for the color control
@Orpheusp made a couple minor changes:
Great first contribution 👏 👏 👏 |
This was referenced Dec 28, 2020
This was referenced Nov 25, 2023
This was referenced Nov 26, 2023
This was referenced Nov 27, 2023
This was referenced Nov 27, 2023
This was referenced May 13, 2024
This was referenced May 14, 2024
This was referenced May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #10167
What I did
SketchPickerProps.presetColors
for the color control component.How to test
If your answer is yes to any of these, please make sure to include it in your PR.