Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addon-docs: Automatic source selection based on story type #11601

Merged
merged 5 commits into from
Jul 18, 2020
Merged

Addon-docs: Automatic source selection based on story type #11601

merged 5 commits into from
Jul 18, 2020

Conversation

shilman
Copy link
Member

@shilman shilman commented Jul 18, 2020

Issue: #11526

What I did

  • Add a new story parameter docs.source.type
  • Use the type to determine which snippet to render

What this change means for users:

  • No-args stories will go back to using the raw source code unless otherwise specified
  • Args stories will use the dynamically-rendered source unless otherwise specified

How to test

See updated stories in official-storybook

@shilman shilman requested a review from usulpro as a code owner July 18, 2020 06:33
@shilman shilman added this to the 6.1 docs milestone Jul 18, 2020
tmeasday
tmeasday reviewed Jul 18, 2020
View reviewed changes
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of this might be existing code?

addons/docs/src/blocks/Source.tsx Show resolved Hide resolved
addons/docs/src/blocks/Source.tsx Outdated Show resolved Hide resolved
addons/docs/src/blocks/Source.tsx Outdated Show resolved Hide resolved
@shilman shilman changed the title Addon-docs: Support automatic source selection based on story type Addon-docs: Automatic source selection based on story type Jul 18, 2020
@shilman shilman modified the milestones: 6.1 docs, 6.0 docs Jul 18, 2020
@shilman shilman merged commit 1874040 into next Jul 18, 2020
This was referenced Jul 18, 2020
Closed
Merged
@shilman shilman mentioned this pull request Jul 30, 2020
Closed
This was referenced Dec 28, 2020
Open
Closed
Closed
Open
Open
Closed
Open
Open
Open
Open
Open
@lili2311 lili2311 mentioned this pull request Sep 26, 2023
Open
This was referenced Nov 25, 2023
Open
Open
Open
Open
Open
Open
This was referenced Nov 26, 2023
Open
Open
@azl397985856 azl397985856 mentioned this pull request Nov 27, 2023
Open
This was referenced Nov 27, 2023
Open
Open
Open
This was referenced Nov 27, 2023
Open
Open
@azl397985856 azl397985856 mentioned this pull request May 13, 2024
Open
This was referenced May 13, 2024
Open
Open
Open
This was referenced May 13, 2024
Open
Open
Open
Open
Open
Open
This was referenced May 14, 2024
Open
Open
@adrukh adrukh mentioned this pull request May 14, 2024
Open
This was referenced May 20, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmeasday tmeasday tmeasday approved these changes

@usulpro usulpro Awaiting requested review from usulpro

Assignees
No one assigned
Labels
addon: docs block: source feature request
Projects
None yet
Milestone
6.0 docs
Development

Successfully merging this pull request may close these issues.
2 participants
@shilman @tmeasday