Core: Deprecate configure and clearDecorators #11431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids us having to solve #10005 right now and is consistent with the stories entry.
(So it is easier to have a trailing arg)
tmeasday
requested review from
alterx,
igor-dv,
kazupon,
shilman and
thomasbertet
as code owners
tmeasday
commented
Jul 6, 2020
| @@ -1,6 +1,3 @@ | |||
| import { configure } from '@storybook/{{framework}}'; | |||
|
|
|||
| // eslint-disable-next-line no-underscore-dangle | |||
| module._StorybookPreserveDecorators = true; | |||
There was a problem hiding this comment.
This wasn't doing anything any more anyway.
tmeasday
force-pushed
the
10005-deprecate-configure
branch
from
74f0a19
to
1d08802
Compare
shilman
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: for #10005
What I did
main.js:storiesHow to test
Try adding a
configure()call topreview.jsin official SB