Skip to content

Composition: Zero-config composition from dependencies#10753

Merged
shilman merged 1 commit into
nextfrom
tech/auto-load-ref
May 12, 2020
Merged

Composition: Zero-config composition from dependencies#10753
shilman merged 1 commit into
nextfrom
tech/auto-load-ref

Conversation

@ndelangen
Copy link
Copy Markdown
Member

Issue: #10528

What I did

Added the feature

@ndelangen ndelangen added this to the 6.0 milestone May 12, 2020
@ndelangen ndelangen requested a review from shilman May 12, 2020 15:50
@ndelangen ndelangen self-assigned this May 12, 2020
@shilman shilman modified the milestones: 6.0, 6.0 composition May 12, 2020
@shilman shilman changed the title ADD auto-load refs from package.json to storybook composition feature Composition: Zero-config composition May 12, 2020
Copy link
Copy Markdown
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! And simple! I assume versioning and authentication will come separately?

@shilman shilman changed the title Composition: Zero-config composition Composition: Zero-config composition from dependencies May 12, 2020
@shilman shilman merged commit 3ca7455 into next May 12, 2020
@tmeasday
Copy link
Copy Markdown
Member

Can we add tests for this somehow @ndelangen ?

@ndelangen
Copy link
Copy Markdown
Member Author

auth & versioning is just part of the normal refs loading code in lib/ui @shilman

@tmeasday I tested this locally of course. But I don't have any proper published packages with the storybook field in their package.json.

I can add some unit-tests possibly.

@ndelangen ndelangen deleted the tech/auto-load-ref branch May 13, 2020 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants