Clarify warning message #10225
Merged
Clarify warning message #10225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndelangen
approved these changes
Apr 15, 2020
ndelangen
added
cra
ndelangen
removed
the
patch:yes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10213 (clarifies docs which are logged to screen for CRA users).
Issue:
What I did
Clarified language so people less familiar with Storybook don't make the same mistake I did (see #10213) 🤣
How to test
This is just update to the documentation so presumably it needs no testing.
Otherwise, to see the effect, CRA users should just ensure that the they have an empty 'addons' field in
.storybook/main.jsas that should trigger the message to be logged.