-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: accidentally ending a title with a /
breaks storybook
#26642
Comments
@vanessayuenn I would like to take this issue. I just have some doubts about what is the optimal solution in this scenario. Do we allow the creation of the story by checking if there is nothing after the "/" or we contain the error to that story and allow the rest of the stories to be rendered? |
@hmcostaa The current behavior is mostly correct. Having a Full text:
I think it should show a more useful error like:
I could imagine a different UI that shows the rest of the stories and ALSO surfaces the story errors. But that's a much bigger change. |
…render all components in story that were correctly created. Instead of displaying the message: "Invalid part '${name}', leading to id === parentId ('${id}'), inside title '${title}'", now we have a better message that clarifys the error and then all other components created correctly will be displayed along side the error message
Describe the bug
with a title like:
Storybook fails to compile
To Reproduce
create a story with this title:
System
Additional context
The text was updated successfully, but these errors were encountered: