Skip to content

Handle private composed Storybooks in MCP proxy #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kasperpeulen wants to merge 6 commits into from
Closed

Handle private composed Storybooks in MCP proxy #235

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e9bb785
Handle private composed Storybooks in MCP proxy
kasperpeulen May 21, 2026
36a9e42
Model private composed Storybooks as source errors
kasperpeulen May 22, 2026
6f6ad84
Avoid parameter property in MCP source error
kasperpeulen May 22, 2026
0e740dd
Address MCP composition review comments
kasperpeulen May 22, 2026
0af6d9f
Keep source manifest failures data-only
kasperpeulen May 22, 2026
c3059b2
Refine private source manifest flow
kasperpeulen May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/private-composition-proxy.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"@storybook/addon-mcp": patch
"@storybook/mcp": patch
---

Handle private composed Storybooks when documentation requests come through the Storybook MCP proxy.
Private composed refs now stay visible and return normal guidance to use the source Storybook's MCP endpoint instead of surfacing as tool errors.
144 changes: 72 additions & 72 deletions apps/internal-storybook/pnpm-lock.yaml
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion apps/internal-storybook/tests/check-deps.e2e.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,5 +43,5 @@ describe('Storybook Dependencies', () => {
`Storybook dependencies are outdated. Update the catalog in pnpm-workspace.yaml:\n\n sed -i '' 's/${currentVersion}/${latestVersion}/g' pnpm-workspace.yaml && pnpm install\n\nOutdated packages:\n${outdatedList}`,
);
}
});
}, 60_000);
});
2 changes: 1 addition & 1 deletion apps/internal-storybook/tests/mcp-composition-auth.e2e.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import {
const PORT = 6008;
const MCP_ENDPOINT = `http://localhost:${PORT}/mcp`;
const WELL_KNOWN_ENDPOINT = `http://localhost:${PORT}/.well-known/oauth-protected-resource`;
const STARTUP_TIMEOUT = 30_000;
const STARTUP_TIMEOUT = 60_000;
Comment thread
kasperpeulen marked this conversation as resolved.

let storybookProcess: ReturnType<typeof x> | null = null;

Expand Down
2 changes: 1 addition & 1 deletion apps/internal-storybook/tests/mcp-composition.e2e.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import {

const PORT = 6007;
const MCP_ENDPOINT = `http://localhost:${PORT}/mcp`;
const STARTUP_TIMEOUT = 30_000;
const STARTUP_TIMEOUT = 60_000;

let storybookProcess: ReturnType<typeof x> | null = null;

Expand Down
2 changes: 1 addition & 1 deletion apps/internal-storybook/tests/mcp-endpoint.e2e.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import {

const PORT = 6006;
const MCP_ENDPOINT = `http://localhost:${PORT}/mcp`;
const STARTUP_TIMEOUT = 30_000;
const STARTUP_TIMEOUT = 60_000;

let storybookProcess: ReturnType<typeof x> | null = null;

Expand Down
98 changes: 49 additions & 49 deletions eval/pnpm-lock.yaml
View file
Open in desktop

Large diffs are not rendered by default.

44 changes: 22 additions & 22 deletions packages/addon-mcp/pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading