Improvements #66
Merged
Improvements #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
package.json
Outdated
| @@ -31,6 +31,9 @@ | |||
| "he": "^1.1.1", | |||
| "marked": "^0.3.12" | |||
| }, | |||
| "jest": { | |||
| "testURL": "http://localhost/" | |||
| }, | |||
There was a problem hiding this comment.
Instead you can upgrade to jest 23.5.0 which fixes this issue.
jestjs/jest#6792
There was a problem hiding this comment.
Ah, nice, they fixed it! Thanks! Rebased now :)
christianalfoni
force-pushed
the
improvements
branch
from
bd1c29b
to
62eb666
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys,
I have fixed an issue related to large bundle sizes. Now you can use plain
marksyimport to create components, using the conventionalh.This has exactly the same effect as using jsx, but without the large bundle size.
Other fixes:
You now import
marksy/jsxinstead ofmarksy/components, since you now have components available by default. I have added a deprecation warning to the previous import, which still worksI have fixed the tests with a Jest config
I guess that is it! Hope you like it, cause I really need for a project ;-)