This repository was archived by the owner on Aug 18, 2025. It is now read-only.
Add new Callout design for recipes and docs#616
Merged
Conversation
added 17 commits
October 31, 2023 18:22
✅ Deploy Preview for storybook-frontpage ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
2 tasks
kylegach
reviewed
Nov 3, 2023
kylegach
reviewed
Nov 6, 2023
kylegach
reviewed
Nov 6, 2023
kylegach
reviewed
Nov 6, 2023
kylegach
reviewed
Nov 6, 2023
kylegach
reviewed
Nov 6, 2023
kylegach
reviewed
Nov 6, 2023
kylegach
reviewed
Nov 6, 2023
kylegach
reviewed
Nov 6, 2023
kylegach
reviewed
Nov 6, 2023
kylegach
reviewed
Nov 6, 2023
| @@ -1,18 +1,12 @@ | |||
| <div class="aside aside__no-top"> | |||
| <Callout variant="neutral" icon="ℹ️" title="Prerequisites" style={{ marginBottom: '10px' }}> | |||
Collaborator
There was a problem hiding this comment.
Instead of an inline style, can we refactor this CSS to be a better fit for what we're after? Looks like it should target ps that immediately following a heading?
p:first-of-type:not(:only-of-type) {
margin-top: 0;
}
kylegach
reviewed
Nov 6, 2023
| <Callout variant="neutral" icon="ℹ️" title="Prerequisites"> | ||
|
|
||
| This recipe assumes that you have a React app using Tailwind CSS and have just set up Storybook >=7.0 using the [getting started guide](/docs/react/get-started/install). Don’t have this? Follow Tailwind's [setup instructions](https://tailwindcss.com/docs/installation) then run: | ||
| This recipe assumes that you have a React app using Tailwind CSS and have just set up **Storybook >=7.0** using the [getting started guide](/docs/react/get-started/install). Don’t have this? Follow Tailwind's [setup instructions](https://tailwindcss.com/docs/installation) then run: |
Collaborator
There was a problem hiding this comment.
For the prerequisites callouts, I think this one has the best prose & formatting. Can we make it consistent with the others?
kylegach
reviewed
Nov 6, 2023
kylegach
reviewed
Nov 6, 2023
kylegach
left a comment
kylegach
left a comment
Collaborator
There was a problem hiding this comment.
The new Callouts look and perform so much better than div.aside. 👏
And the significantly streamlined recipes feel much more useful, too.
Callout code looks great! Left a bunch of suggestions for the recipes.
Co-authored-by: Kyle Gach <kyle.gach@gmail.com>
kylegach
approved these changes
Nov 6, 2023
kylegach
left a comment
kylegach
left a comment
Collaborator
There was a problem hiding this comment.
Appreciate these nice improvements!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
.asidein recipes with Callout