This repository was archived by the owner on Aug 18, 2025. It is now read-only.
Handle versioned links in relative-to-root-links#555
Merged
Conversation
- ../../../release-6-5/docs/api/csf.md -> /docs/6.5/react/api/csf.md - Add tests
✅ Deploy Preview for storybook-frontpage ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Contributor
There was a problem hiding this comment.
Thank you for adding tests 🙏🏽
Collaborator
Author
There was a problem hiding this comment.
Thanks for the ultra-quick review!
winkerVSbecks
approved these changes
Jun 7, 2023
5 tasks
kylegach
added a commit
to storybookjs/storybook
that referenced
this pull request
Jun 7, 2023
- Per storybookjs/frontpage#555, it's no longer necessary
kylegach
added a commit
that referenced
this pull request
Jun 8, 2023
- No longer used, per #555 & storybookjs/storybook#22966 - Simplify `relativeToRootLinks`
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This approach will eventually1 replace
LinkWithVersion. It allows for functional links when viewing on GitHub.../../../release-6-5/docs/api/csf.md→/docs/6.5/react/api/csf.mdFootnotes
For now,
LinkWithVersionremains available in MDX, so that I can update the actual docs content in the monorepo. After that, I'll remove that component, as it is no longer necessary. ↩