Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Init SWC addon #1

Merged
merged 2 commits into from
Jan 4, 2024
Merged

Conversation

valentinpalkovic
Copy link
Contributor

@valentinpalkovic valentinpalkovic commented Jan 4, 2024

I have set up a Storybookaddon to add SWC as a compiler for Webpack5-based projects.

📦 Published PR as canary version: 0.0.1--canary.1.c210998.0

✨ Test out this PR locally via:

npm install @storybook/[email protected]
# or 
yarn add @storybook/[email protected]

Copy link

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
tsup 8.0.1 eval, filesystem, environment +6 36.3 MB egoist
auto 11.0.4 filesystem, environment +6 33.4 MB alisowski
@biomejs/biome 1.4.1 None +0 89.7 kB dominionl
typescript 5.3.3 filesystem +0 32 MB typescript-bot

@valentinpalkovic valentinpalkovic added the major Increment the major version when merged label Jan 4, 2024
Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Issue Package Version Note Source
New author handlebars 4.7.8
Uses eval handlebars 4.7.8
Shell access esbuild 0.18.20
Shell access update-browserslist-db 1.0.13
Uses eval rollup 4.9.2
Uses eval tsup 8.0.1
Uses eval terser 5.26.0

Next steps

What is new author?

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights.

What is eval?

Package uses eval() which is a dangerous function. This prevents the code from running in certain environments and increases the risk that the code may contain exploits or malicious behavior.

Avoid packages that use eval, since this could potentially execute any code.

What is shell access?

This module accesses the system shell. Accessing the system shell increases the risk of executing arbitrary code.

Packages should avoid accessing the shell which can reduce portability, and make it easier for malicious shell access to be introduced.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] bar@* or ignore all packages with @SocketSecurity ignore-all

@valentinpalkovic valentinpalkovic force-pushed the valentin/init-swc-compiler-addon branch from 073b57f to 0ce3c97 Compare January 4, 2024 15:01
README.md Outdated Show resolved Hide resolved
Co-authored-by: Yann Braga <[email protected]>
Copy link
Member

@yannbf yannbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@valentinpalkovic valentinpalkovic merged commit 2dde568 into main Jan 4, 2024
3 of 4 checks passed
@valentinpalkovic valentinpalkovic deleted the valentin/init-swc-compiler-addon branch January 4, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major Increment the major version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants