Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Replace deprecated context="module" with module #217

Merged
merged 6 commits into from
Oct 22, 2024

Conversation

xeho91
Copy link
Collaborator

@xeho91 xeho91 commented Oct 19, 2024

Resolves #204

📦 Published PR as canary version: 4.1.8--canary.217.c3e75ce.0

✨ Test out this PR locally via:

npm install @storybook/[email protected]
# or 
yarn add @storybook/[email protected]

Version

Published prerelease version: v5.0.0-next.7

Changelog

💥 Breaking Change

🚀 Enhancement

🐛 Bug Fix

  • refactor: Replace deprecated context="module" with module #217 (@xeho91)
  • fix(pre-transform): Move stories target component import declaration from instance to module tag #218 (@xeho91)
  • v5: Fix tags being ignored #206 (@JReinhold)
  • fix(parser): Resolve autodocs tag issue and extracting rawCode #201 (@xeho91)
  • Replace lodash usage with es-toolkit #192 (@JReinhold)
  • chore: use dist folder to load the files #185 (@benoitf)

⚠️ Pushed to next

  • fix typing issue in Example.stories.svelte (@xeho91)
  • remove obsolete test (@xeho91)

🏠 Internal

  • refactor: Improve AST-related types readability & fix existing issues #209 (@xeho91)

Authors: 4

@xeho91 xeho91 added the patch Increment the patch version when merged label Oct 19, 2024
@xeho91 xeho91 requested a review from JReinhold October 19, 2024 04:54
@JReinhold
Copy link
Collaborator

Shouldn't the tests for the legacy API transformation stay on the old syntax? To ensure it works even if users haven't migrated to the new module syntax yet?

@xeho91
Copy link
Collaborator Author

xeho91 commented Oct 19, 2024

Shouldn't the tests for the legacy API transformation stay on the old syntax? To ensure it works even if users haven't migrated to the new module syntax yet?

Valid point, reverted.

@JReinhold JReinhold merged commit b74aee0 into next Oct 22, 2024
6 of 7 checks passed
@shilman
Copy link
Member

shilman commented Oct 22, 2024

🚀 PR was released in v5.0.0-next.7 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged prerelease This change is available in a prerelease.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants