fix: move MetaProps to its own declaration to allow for overrides #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscard0m
approved these changes
Sep 13, 2023
|
✅ but wait for @JReinhold's review |
|
FYI the Meta tag will be deprecated soon. |
Oh yeah I saw that discussion...well until then 😄 also this could help to keep the typing this way when the meta is moved to the module script |
|
Do I need to do something else before merging? |
|
🚀 PR was released in |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now the Meta class doesn't have a Props interface. This make it impossible to add overrides to the props (i'm using interface merging to provide intellisense for some parameters)
With this simple change the users will be able to augment the the typing of the Meta component