-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Supports for tags in <Meta/> #134
Conversation
Cool! Just FYI, @JReinhold had another idea regarding |
5c86b26
to
c48e985
Compare
4d942cf
to
d6ae8c9
Compare
d88b6ba
to
1594d8d
Compare
@JReinhold are you Ok with theses changes ? thanks ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! This is exciting!
@j3rem1e just a quick heads up that there's a merge conflict |
1594d8d
to
74c982c
Compare
It should be good now. And I included your changes |
🚀 PR was released in |
🚀 PR was released in |
1 similar comment
🚀 PR was released in |
I'm not sure if this is the correct place to mention this but since this PR was released only a few days ago i am hoping this would get noticed. Using the express meta as JS results in a error: 'TypeError: Cannot read properties of undefined (reading 'DefaultExample')' Eg:
When using the depreated
This happens right after a clean install of a sveltekit app. A repository that showcases this can be found here I'm not sure if this is a mismatch in configuration or a possible bug? |
Thanks for reporting it. I'll check that. |
It's a typo on the documentation. It's not |
@j3rem1e Ah yes. I literally took over what was on the documentation and did not notice it :), thanks for pointing it out! |
Storybook v7 supports tag on the meta property. However, tags should be set on the story indexer to be seen by the autodocs feature. The only tag used today by storybook is
autodocs
AFAIK.This PR add supports for tags and an alias to a 'autodocs' property. Tags can only be specified as a static property, because it should be build by parsing the AST.
Examples: