Fix: typeof Meta in Svelte v3 (Pin Svelte peer dependency to v3)
#127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
JReinhold
changed the title
typeof Meta in Svelte v3 (Pin Svelte peer dependency to v3)
JReinhold
added
bug
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works on #121 (comment)
cc @RSWilli
This PR pins the allowed Svelte version to v3, because it's not possible to provide correct typings for Svelte v3 and v4 at the same time. It also reverts the type changes in #112 so it matches that of Svelte v3.
This will be released as a patch version, and then shortly after #128 that pins to Svelte v4 will be released as a major, requiring any Svelte v4 users to upgrade this addon with the breaking change.
I've tested that this makes types work by installing this canary in a Svelte v3 project and see that it works, where the current latest release of this addon makes the types fail similar to #121.
📦 Published PR as canary version:
3.0.10--canary.127.893640b.0✨ Test out this PR locally via: