Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Python 3.13 wheel building and switch to C17 C standard #124

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

djhoese
Copy link
Collaborator

@djhoese djhoese commented Sep 4, 2024

See https://py-free-threading.github.io/debugging/

We were getting:

  In file included from pykdtree/kdtree.c:13538:
  In file included from /Users/runner/miniforge3/conda-bld/pykdtree_1725442308828/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/include/python3.13/internal/pycore_frame.h:13:
  /Users/runner/miniforge3/conda-bld/pykdtree_1725442308828/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/include/python3.13/internal/pycore_code.h:540:15: error: expected parameter declarator
    540 | static_assert(COLD_EXIT_INITIAL_VALUE > ADAPTIVE_COOLDOWN_VALUE,
        |               ^
  /Users/runner/miniforge3/conda-bld/pykdtree_1725442308828/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/include/python3.13/internal/pycore_backoff.h:125:33: note: expanded from macro 'COLD_EXIT_INITIAL_VALUE'
    125 | #define COLD_EXIT_INITIAL_VALUE 64
        |                                 ^
  In file included from pykdtree/kdtree.c:13538:
  In file included from /Users/runner/miniforge3/conda-bld/pykdtree_1725442308828/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/include/python3.13/internal/pycore_frame.h:13:
  /Users/runner/miniforge3/conda-bld/pykdtree_1725442308828/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/include/python3.13/internal/pycore_code.h:540:15: error: expected ')'
  /Users/runner/miniforge3/conda-bld/pykdtree_1725442308828/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/include/python3.13/internal/pycore_backoff.h:125:33: note: expanded from macro 'COLD_EXIT_INITIAL_VALUE'
    125 | #define COLD_EXIT_INITIAL_VALUE 64
        |                                 ^
  /Users/runner/miniforge3/conda-bld/pykdtree_1725442308828/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/include/python3.13/internal/pycore_code.h:540:14: note: to match this '('
    540 | static_assert(COLD_EXIT_INITIAL_VALUE > ADAPTIVE_COOLDOWN_VALUE,
        |              ^
  /Users/runner/miniforge3/conda-bld/pykdtree_1725442308828/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/include/python3.13/internal/pycore_code.h:540:1: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int]
    540 | static_assert(COLD_EXIT_INITIAL_VALUE > ADAPTIVE_COOLDOWN_VALUE,
        | ^
        | int
  3 errors generated.

Hopefully fixes it, but I need to read more into if we should be doing more to protect against free-threaded Python 3.13.

@djhoese djhoese merged commit fd76dd7 into storpipfugl:master Sep 4, 2024
6 checks passed
@djhoese djhoese deleted the enable-py313 branch September 4, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant