Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Tree Capacity #1

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

llucid-97
Copy link

Hi, I've been playing with your repo trying to get a PER implementation working.
I notice the SumTree 's get() method doesn't retrieve data correctly unless the capacity is a power of two because of this logic in the _retrieve method:

        left = 2 * idx + 1
        right = left + 1

        if left >= len(self.tree):
            return idx

if the tree capacity is not a power of two, the recursion terminates exits at the wrong index (either going past or stopping before where it should).
I've added an assertion to check for this, and a bit of logic to make it easy to set the capacity without having to worry about this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant