Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I've been playing with your repo trying to get a PER implementation working.
I notice the
SumTree
's get() method doesn't retrieve data correctly unless the capacity is a power of two because of this logic in the_retrieve
method:if the tree capacity is not a power of two, the recursion terminates exits at the wrong index (either going past or stopping before where it should).
I've added an assertion to check for this, and a bit of logic to make it easy to set the capacity without having to worry about this