Skip to content

Conversation

@renovate
Copy link
Contributor

@renovate renovate bot commented Mar 29, 2024

This PR contains the following updates:

Package Change Age Confidence
express (source) 4.18.3 -> 4.20.0 age confidence

GitHub Vulnerability Alerts

CVE-2024-29041

Impact

Versions of Express.js prior to 4.19.2 and pre-release alpha and beta versions before 5.0.0-beta.3 are affected by an open redirect vulnerability using malformed URLs.

When a user of Express performs a redirect using a user-provided URL Express performs an encode using encodeurl on the contents before passing it to the location header. This can cause malformed URLs to be evaluated in unexpected ways by common redirect allow list implementations in Express applications, leading to an Open Redirect via bypass of a properly implemented allow list.

The main method impacted is res.location() but this is also called from within res.redirect().

Patches

expressjs/express@0867302
expressjs/express@0b74695

An initial fix went out with [email protected], we then patched a feature regression in 4.19.1 and added improved handling for the bypass in 4.19.2.

Workarounds

The fix for this involves pre-parsing the url string with either require('node:url').parse or new URL. These are steps you can take on your own before passing the user input string to res.location or res.redirect.

References

https://github.com/expressjs/express/pull/5539
https://github.com/koajs/koa/issues/1800
https://expressjs.com/en/4x/api.html#res.location

CVE-2024-43796

Impact

In express <4.20.0, passing untrusted user input - even after sanitizing it - to response.redirect() may execute untrusted code

Patches

this issue is patched in express 4.20.0

Workarounds

users are encouraged to upgrade to the patched version of express, but otherwise can workaround this issue by making sure any untrusted inputs are safe, ideally by validating them against an explicit allowlist

Details

successful exploitation of this vector requires the following:

  1. The attacker MUST control the input to response.redirect()
  2. express MUST NOT redirect before the template appears
  3. the browser MUST NOT complete redirection before:
  4. the user MUST click on the link in the template

Release Notes

expressjs/express (express)

v4.20.0

Compare Source

==========

  • deps: serve-static@​0.16.0
    • Remove link renderization in html while redirecting
  • deps: send@​0.19.0
    • Remove link renderization in html while redirecting
  • deps: body-parser@​0.6.0
    • add depth option to customize the depth level in the parser
    • IMPORTANT: The default depth level for parsing URL-encoded data is now 32 (previously was Infinity)
  • Remove link renderization in html while using res.redirect
  • deps: path-to-regexp@​0.1.10
    • Adds support for named matching groups in the routes using a regex
    • Adds backtracking protection to parameters without regexes defined
  • deps: encodeurl@~2.0.0
    • Removes encoding of \, |, and ^ to align better with URL spec
  • Deprecate passing options.maxAge and options.expires to res.clearCookie
    • Will be ignored in v5, clearCookie will set a cookie with an expires in the past to instruct clients to delete the cookie

v4.19.2

Compare Source

==========

  • Improved fix for open redirect allow list bypass

v4.19.1

Compare Source

==========

  • Allow passing non-strings to res.location with new encoding handling checks

v4.19.0

Compare Source

==========

  • Prevent open redirect allow list bypass due to encodeurl
  • deps: cookie@​0.6.0

Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot requested a review from sullivanpj as a code owner March 29, 2024 12:18
@renovate renovate bot requested a review from sullivanpj March 29, 2024 12:18
stormie-bot
stormie-bot previously approved these changes Mar 29, 2024
@stormie-bot stormie-bot enabled auto-merge (squash) March 29, 2024 12:18
@socket-security
Copy link

socket-security bot commented Mar 29, 2024

All alerts resolved. Learn more about Socket for GitHub.

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report

@renovate renovate bot changed the title fix(deps): update dependency express to v4.19.2 [security] fix(deps): update dependency express to v4.20.0 [security] Sep 17, 2024
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch from 5811dff to cc37e2a Compare January 23, 2025 18:29
Copy link
Member

@stormie-bot stormie-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review by ChatGPT

stormie-bot
stormie-bot previously approved these changes Jan 23, 2025
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch from cc37e2a to d15e926 Compare January 30, 2025 17:11
stormie-bot
stormie-bot previously approved these changes Jan 30, 2025
Copy link
Member

@stormie-bot stormie-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review by ChatGPT

@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch from d15e926 to bc504d0 Compare February 9, 2025 13:54
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch from bc504d0 to 5434288 Compare March 3, 2025 17:33
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch 3 times, most recently from a6107f6 to daa1703 Compare March 17, 2025 13:08
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch from daa1703 to f89a479 Compare April 1, 2025 12:08
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch from f89a479 to e644daf Compare April 8, 2025 14:48
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch from e644daf to 7b295ef Compare April 24, 2025 07:29
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch from 7b295ef to 65287ba Compare May 19, 2025 20:40
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch 2 times, most recently from b9c1855 to 83444be Compare June 4, 2025 12:35
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch from 83444be to 684797c Compare June 22, 2025 13:08
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch from 684797c to fc70b0f Compare July 2, 2025 13:57
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch 2 times, most recently from f524a6d to 17d9a22 Compare August 13, 2025 14:27
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch from 17d9a22 to 6130577 Compare August 19, 2025 19:30
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch from 6130577 to 71603b7 Compare August 31, 2025 10:15
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch from 71603b7 to b46d37f Compare September 25, 2025 16:01
@renovate renovate bot changed the title fix(deps): update dependency express to v4.20.0 [security] chore(deps): update dependency express to v4.20.0 [security] Sep 25, 2025
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch from b46d37f to 6260082 Compare October 21, 2025 15:49
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch from 6260082 to 0033010 Compare November 10, 2025 23:56
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch from 0033010 to e7c9081 Compare November 19, 2025 00:54
@renovate renovate bot changed the title chore(deps): update dependency express to v4.20.0 [security] chore(deps): update dependency express to v4.22.0 [security] Dec 2, 2025
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch 2 times, most recently from 026f346 to 33c1f48 Compare December 3, 2025 06:55
@renovate renovate bot changed the title chore(deps): update dependency express to v4.22.0 [security] chore(deps): update dependency express to v4.20.0 [security] Dec 3, 2025
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch from 33c1f48 to a52c810 Compare December 3, 2025 19:45
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch from a52c810 to 96be1e1 Compare December 6, 2025 13:18
@renovate renovate bot requested a review from a team December 6, 2025 13:18
@renovate renovate bot changed the title chore(deps): update dependency express to v4.20.0 [security] chore(deps): update dependency express to v4.20.0 [security] - autoclosed Dec 17, 2025
@renovate renovate bot closed this Dec 17, 2025
auto-merge was automatically disabled December 17, 2025 07:48

Pull request was closed

@renovate renovate bot deleted the renovate/npm-express-vulnerability branch December 17, 2025 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants