Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add basic implementation of ddsketch #1

Merged
merged 11 commits into from
Mar 7, 2023
Merged

feat: add basic implementation of ddsketch #1

merged 11 commits into from
Mar 7, 2023

Conversation

btkostner
Copy link
Contributor

@btkostner btkostner commented Mar 4, 2023

This adds a basic implementation of the sketches-go library needed for data streams to work.

Things that will need to be added in (in this PR or later):

  • tests to ensure it works with the same result as the golang library
  • more documentation (examples)
  • possibly look at other more optimized data stores for Elixir and Erlang?

@btkostner btkostner self-assigned this Mar 4, 2023
@btkostner
Copy link
Contributor Author

Worth mentioning, in my beta version of this library with Kafee, I used https://github.com/moosecodebv/dog_sketch, though I'm getting issues with numbers due to how things are encoded. Hopefully bringing this in to the library will help solve those issues.

@btkostner btkostner requested a review from msutkowski March 4, 2023 06:06
@btkostner
Copy link
Contributor Author

Oooof, that took a bit longer than expected. It should now be feature complete for the sketch implementation. Confirmed matching with the golang implementation on how it exports data.

@btkostner btkostner enabled auto-merge (squash) March 7, 2023 02:37
@btkostner btkostner disabled auto-merge March 7, 2023 20:11
@btkostner btkostner merged commit 125b5ed into main Mar 7, 2023
@btkostner btkostner deleted the sketch branch March 7, 2023 20:11
btkostner pushed a commit that referenced this pull request Apr 24, 2023
🤖 I have created a release *beep* *boop*
---


## 1.0.0 (2023-04-06)


### ⚠ BREAKING CHANGES

* Package and application configuration is now under `data_streams`
instead of `dd_data_streams`

### Features

* add basic implementation of ddsketch
([#1](#1))
([125b5ed](125b5ed))
* add basic kafka tracking support with data streams
([#3](#3))
([bfc6a0b](bfc6a0b))
* add LICENSE file
([#11](#11))
([6c5668f](6c5668f))
* link open telemetry span to current pathway context
([#5](#5))
([e0ed9b2](e0ed9b2))
* rename dd_data_streams to data_streams
([#9](#9))
([a0d1742](a0d1742))


### Bug Fixes

* add case for error http status
([#8](#8))
([ef4a95d](ef4a95d))
* **ci:** update PR title regex check
([64ef99f](64ef99f))
* dialyzer warnings for kafka integration map
([18bf936](18bf936))
* filter out nil values from kafka integration tags
([b33926f](b33926f))
* update kafka integration to not set context on produce
([#7](#7))
([6807b6d](6807b6d))
* update otel resource service configuration
([adb9890](adb9890))
* update tag logic to be more consistant
([#4](#4))
([48d13df](48d13df))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant