Add support for creating shared LVM setups #1123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vojtechtrefny
force-pushed
the
3.8-devel_shared-vg
branch
from
55e3ede
to
3445c27
Compare
japokorn
previously approved these changes
Aug 23, 2023
japokorn
dismissed
their stale review
Further testing the subjest revealed a probable issue.
|
When creating the first shared VG (and using Ref: lvmlockd(8) 'Creating the first sanlock VG'. |
This feature is requested by GFS2 for the storage role. This adds support for creating shared VGs and activating LVs in shared mode.
When creating the first shared VG (and using sanlock lock manager) vgcreate has to be given non-PV device otherwise VG creation will fail.
We need to be able to skip pvcreate when creating a shared VG and that is not possible with LVM DBusD.
vojtechtrefny
force-pushed
the
3.8-devel_shared-vg
branch
from
3445c27
to
29d412f
Compare
I added two more commits that should address this -- we don't really need to run |
japokorn
approved these changes
Sep 13, 2023
There was a problem hiding this comment.
tl;dr: LGTM
Since the goal is the support of gfs2 we need not to support sanlock (which requires the non-PV thing).
Instead dlm lock manager is required.
I managed to test shared VG creation using storage role and ha_cluster system role.
I think this PR can be merged.
japokorn
added a commit
to japokorn/storage
that referenced
this pull request
Oct 2, 2023
- feature requested by GFS2 - adds support for creating shared VGs - shared LVM setup needs lvmlockd service with dlm lock manager to be running - to test this change ha_cluster system role is used to set up degenerated cluster on localhost - requires blivet version with shared LVM setup support (storaged-project/blivet#1123) Note: The test is incomplete. The part of it is commented out. Running the complete test will result in LVM crash and will corrupt the machine. Until resolved, this PR should not be merged.
japokorn
added a commit
to japokorn/storage
that referenced
this pull request
Oct 3, 2023
- feature requested by GFS2 - adds support for creating shared VGs - shared LVM setup needs lvmlockd service with dlm lock manager to be running - to test this change ha_cluster system role is used to set up degenerated cluster on localhost - requires blivet version with shared LVM setup support (storaged-project/blivet#1123) Note: The test is incomplete. The part of it is commented out. Running the complete test will result in LVM crash and will corrupt the machine. Until resolved, this PR should not be merged.
japokorn
added a commit
to japokorn/storage
that referenced
this pull request
Oct 12, 2023
- feature requested by GFS2 - adds support for creating shared VGs - shared LVM setup needs lvmlockd service with dlm lock manager to be running - to test this change ha_cluster system role is used to set up degenerated cluster on localhost - requires blivet version with shared LVM setup support (storaged-project/blivet#1123)
japokorn
added a commit
to japokorn/storage
that referenced
this pull request
Oct 12, 2023
- feature requested by GFS2 - adds support for creating shared VGs - shared LVM setup needs lvmlockd service with dlm lock manager to be running - to test this change ha_cluster system role is used to set up degenerated cluster on localhost - requires blivet version with shared LVM setup support (storaged-project/blivet#1123)
japokorn
added a commit
to japokorn/storage
that referenced
this pull request
Oct 12, 2023
- feature requested by GFS2 - adds support for creating shared VGs - shared LVM setup needs lvmlockd service with dlm lock manager to be running - to test this change ha_cluster system role is used to set up degenerated cluster on localhost - requires blivet version with shared LVM setup support (storaged-project/blivet#1123)
japokorn
added a commit
to japokorn/storage
that referenced
this pull request
Oct 12, 2023
- feature requested by GFS2 - adds support for creating shared VGs - shared LVM setup needs lvmlockd service with dlm lock manager to be running - to test this change ha_cluster system role is used to set up degenerated cluster on localhost - requires blivet version with shared LVM setup support (storaged-project/blivet#1123)
japokorn
added a commit
to japokorn/storage
that referenced
this pull request
Oct 12, 2023
- feature requested by GFS2 - adds support for creating shared VGs - shared LVM setup needs lvmlockd service with dlm lock manager to be running - to test this change ha_cluster system role is used to set up degenerated cluster on localhost - requires blivet version with shared LVM setup support (storaged-project/blivet#1123)
japokorn
added a commit
to japokorn/storage
that referenced
this pull request
Oct 13, 2023
- feature requested by GFS2 - adds support for creating shared VGs - shared LVM setup needs lvmlockd service with dlm lock manager to be running - to test this change ha_cluster system role is used to set up degenerated cluster on localhost - requires blivet version with shared LVM setup support (storaged-project/blivet#1123)
japokorn
added a commit
to japokorn/storage
that referenced
this pull request
Oct 18, 2023
- feature requested by GFS2 - adds support for creating shared VGs - shared LVM setup needs lvmlockd service with dlm lock manager to be running - to test this change ha_cluster system role is used to set up degenerated cluster on localhost - requires blivet version with shared LVM setup support (storaged-project/blivet#1123)
japokorn
added a commit
to japokorn/storage
that referenced
this pull request
Oct 18, 2023
- feature requested by GFS2 - adds support for creating shared VGs - shared LVM setup needs lvmlockd service with dlm lock manager to be running - to test this change ha_cluster system role is used to set up degenerated cluster on localhost - requires blivet version with shared LVM setup support (storaged-project/blivet#1123)
japokorn
added a commit
to japokorn/storage
that referenced
this pull request
Nov 9, 2023
- feature requested by GFS2 - adds support for creating shared VGs - shared LVM setup needs lvmlockd service with dlm lock manager to be running - to test this change ha_cluster system role is used to set up degenerated cluster on localhost - the test will be skipped if run locally due to an issue with underlying services - requires blivet version with shared LVM setup support (storaged-project/blivet#1123)
japokorn
added a commit
to japokorn/storage
that referenced
this pull request
Nov 15, 2023
- feature requested by GFS2 - adds support for creating shared VGs - shared LVM setup needs lvmlockd service with dlm lock manager to be running - to test this change ha_cluster system role is used to set up degenerated cluster on localhost - the test will be skipped if run locally due to an issue with underlying services - requires blivet version with shared LVM setup support (storaged-project/blivet#1123)
japokorn
added a commit
to japokorn/storage
that referenced
this pull request
Nov 15, 2023
- feature requested by GFS2 - adds support for creating shared VGs - shared LVM setup needs lvmlockd service with dlm lock manager to be running - to test this change ha_cluster system role is used to set up degenerated cluster on localhost - the test will be skipped if run locally due to an issue with underlying services - requires blivet version with shared LVM setup support (storaged-project/blivet#1123)
japokorn
added a commit
to japokorn/storage
that referenced
this pull request
Nov 15, 2023
- feature requested by GFS2 - adds support for creating shared VGs - shared LVM setup needs lvmlockd service with dlm lock manager to be running - to test this change ha_cluster system role is used to set up degenerated cluster on localhost - the test will be skipped if run locally due to an issue with underlying services - requires blivet version with shared LVM setup support (storaged-project/blivet#1123)
japokorn
added a commit
to japokorn/storage
that referenced
this pull request
Nov 28, 2023
- feature requested by GFS2 - adds support for creating shared VGs - shared LVM setup needs lvmlockd service with dlm lock manager to be running - to test this change ha_cluster system role is used to set up degenerated cluster on localhost - the test will be skipped if run locally due to an issue with underlying services - requires blivet version with shared LVM setup support (storaged-project/blivet#1123)
japokorn
added a commit
to japokorn/storage
that referenced
this pull request
Nov 28, 2023
- feature requested by GFS2 - adds support for creating shared VGs - shared LVM setup needs lvmlockd service with dlm lock manager to be running - to test this change ha_cluster system role is used to set up degenerated cluster on localhost - the test will be skipped if run locally due to an issue with underlying services - requires blivet version with shared LVM setup support (storaged-project/blivet#1123)
richm
pushed a commit
to linux-system-roles/storage
that referenced
this pull request
Dec 12, 2023
- feature requested by GFS2 - adds support for creating shared VGs - shared LVM setup needs lvmlockd service with dlm lock manager to be running - to test this change ha_cluster system role is used to set up degenerated cluster on localhost - the test will be skipped if run locally due to an issue with underlying services - requires blivet version with shared LVM setup support (storaged-project/blivet#1123)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature is requested by GFS2 for the storage role. This adds support for creating shared VGs and activating LVs in shared mode.