Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make tests use did:web everywhere #397

Merged
merged 1 commit into from
Jan 27, 2023
Merged

Conversation

hugomrdias
Copy link
Contributor

No description provided.

@hugomrdias hugomrdias temporarily deployed to dev January 26, 2023 13:11 — with GitHub Actions Inactive
@hugomrdias hugomrdias added this to the w3up phase 2 milestone Jan 26, 2023
Copy link
Contributor

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -1,4 +1,4 @@
import { Signer } from '@ucanto/principal/ed25519'
// @ts-ignore
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we use ts-expect-error instead? It is easier to flag when it gets fixed

@hugomrdias hugomrdias merged commit c7d5c34 into main Jan 27, 2023
@hugomrdias hugomrdias deleted the fix/did-web-tests branch January 27, 2023 09:15
gobengo pushed a commit that referenced this pull request Jan 31, 2023
🤖 I have created a release *beep* *boop*
---


##
[4.9.0](access-api-v4.8.0...access-api-v4.9.0)
(2023-01-30)


### Features

* access-api handling store/info for space not in db returns failure
with name
([#391](#391))
([9610fcf](9610fcf))
* update @ucanto/* to ~4.2.3
([#405](#405))
([50c0c80](50c0c80))
* update access-api ucanto proxy to not need a signer
([#390](#390))
([71cbeb7](71cbeb7))


### Bug Fixes

* make tests use did:web everywhere
([#397](#397))
([c7d5c34](c7d5c34))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
gobengo pushed a commit that referenced this pull request Apr 11, 2023
gobengo pushed a commit that referenced this pull request Apr 11, 2023
🤖 I have created a release *beep* *boop*
---


##
[4.9.0](access-api-v4.8.0...access-api-v4.9.0)
(2023-01-30)


### Features

* access-api handling store/info for space not in db returns failure
with name
([#391](#391))
([665dac9](665dac9))
* update @ucanto/* to ~4.2.3
([#405](#405))
([ec39443](ec39443))
* update access-api ucanto proxy to not need a signer
([#390](#390))
([163fb74](163fb74))


### Bug Fixes

* make tests use did:web everywhere
([#397](#397))
([00be288](00be288))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants