fix: intermittent test fails #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gozala
force-pushed
the
fix/intermittent-test-fails
branch
from
9bb29c3
to
10e07c3
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have been seeing these kind of failures every now and then https://github.com/web3-storage/ucanto/actions/runs/3605142474/jobs/6075233040. Turns out some tests just compare delegations which may end up different because expiry date is encoded in UCANs, so if wall clock second mark changes between calls we get a different expiry. In tests it may happens because of the await in between.
This pr changes all tests to use fixed expiry to make them clock agnostic