Fix: check server presence correctly in disambiguiation #983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XVincentX
force-pushed
the
fix/check-server-correctly
branch
2 times, most recently
from
d32d133
to
f99bfa2
Compare
XVincentX
force-pushed
the
fix/check-server-correctly
branch
from
f99bfa2
to
c2ac51e
Compare
karol-maciaszek
approved these changes
Feb 13, 2020
|
I know, but you were busy. Just wanted to close this since it's annoying :) |
XVincentX
added a commit
that referenced
this pull request
Feb 13, 2020
* fix: check server presence correctly * test: add harness * test: add router test * docs: changelog line
XVincentX
added a commit
that referenced
this pull request
Feb 13, 2020
* fix: check server presence correctly * test: add harness * test: add router test * docs: changelog line
XVincentX
added a commit
that referenced
this pull request
Feb 20, 2020
* add io-ts * add io-ts-types * rewrite the function to use the new codec * feat: integrate in the server * decoder: fix * test: rewrite * Fix: check server presence correctly in disambiguiation (#983) * fix: check server presence correctly * test: add harness * test: add router test * docs: changelog line * test: add header tests * feat: use parsePreferHeader * refactor: make VSCode happy again * refactor: handle different param names * refactor: not cool, but it works * refactor: simplify * refactor: read configuration only if mock is true * Update packages/http-server/src/getHttpConfigFromRequest.ts Co-Authored-By: Karol Maciaszek <[email protected]> * refactor: it's plural * docs: tell people to use the prefer header * docs: update * docs: changelog line * test: add harness for dynamic as header * docs: difference between header and qs Co-authored-by: Karol Maciaszek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #981
ServerMatch is
undefined, not null.