Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client fixes #959

Merged
merged 12 commits into from
Feb 3, 2020
Merged

Client fixes #959

merged 12 commits into from
Feb 3, 2020

Conversation

XVincentX
Copy link
Contributor

@XVincentX XVincentX commented Feb 3, 2020

  • Adds documentation on partial urls
  • Types the CreatePrism instances for a faster find next time I'll need to refactor them
  • Moves the errors option (it was listed twice!) from the wrong place
  • Small changes in the internal logging creation
  • Removes Error.captureStackTrace(this, ProblemJsonError); — that function is V8 specific and does not work in other browsers

@XVincentX XVincentX marked this pull request as ready for review February 3, 2020 09:52
Copy link
Contributor

@karol-maciaszek karol-maciaszek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@XVincentX XVincentX merged commit 584ced6 into master Feb 3, 2020
@XVincentX XVincentX deleted the feat/browser-fixes branch February 3, 2020 14:27
@@ -81,3 +81,15 @@ For the shortcut methods (since the only mandatory option is intrinsic in the fu
```ts
client.get('https://google.it', { validateRequest: false }).then(response => console.log(response));
```

You can also use relative links when doing requests. In such case you won't be able to use the proxy and the server validation will be disabled:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Root relative. /pet/10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants