fix: 500 only for output validation errors #892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XVincentX
force-pushed
the
fix/500-only-output
branch
from
852942b
to
211c139
Compare
XVincentX
force-pushed
the
fix/500-only-output
branch
from
211c139
to
e0d91bb
Compare
XVincentX
force-pushed
the
fix/500-only-output
branch
4 times, most recently
from
115c1e1
to
0cd2094
Compare
XVincentX
force-pushed
the
fix/500-only-output
branch
2 times, most recently
from
731c912
to
982afe1
Compare
karol-maciaszek
approved these changes
Dec 13, 2019
XVincentX
force-pushed
the
fix/500-only-output
branch
3 times, most recently
from
85a3096
to
0996a9d
Compare
XVincentX
force-pushed
the
fix/500-only-output
branch
from
0996a9d
to
769ee29
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that we were returning a 500 even if there were just Input violations in the current request — but in that case the negotiation process is already giving us the response we want to return; the 500 transformation is only required for output violations.
Please approve but do not merge, so I can bundle this in a patch release.