Fix: schema generation can fail #875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XVincentX
force-pushed
the
fix/schema-gen-crash
branch
3 times, most recently
from
236b91c
to
df12b84
Compare
XVincentX
force-pushed
the
fix/schema-gen-crash
branch
from
df12b84
to
72ba2c2
Compare
karol-maciaszek
suggested changes
Dec 2, 2019
| const instance = generate(schema); | ||
| expect(instance).toHaveProperty('ip'); | ||
| const ip = get(instance, 'ip'); | ||
| assertRight(generate(schema), instance => { |
There was a problem hiding this comment.
Since generate returns Either we should have a test of a failure. Maybe a circular object will do the job?
There was a problem hiding this comment.
Ahi, I didn't see this. Will add.
karol-maciaszek
approved these changes
Dec 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While debugging some JSON Ref issues I noticed that Schema Generation can effectively throw exceptions and would be treated that well.
This PR correctly wraps such situations in
tryCatchstatements.