Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parsing URL-Encoded body for runtime expressions #856

Merged
merged 7 commits into from
Nov 28, 2019
Merged

Parsing URL-Encoded body for runtime expressions #856

merged 7 commits into from
Nov 28, 2019

Conversation

karol-maciaszek
Copy link
Contributor

@karol-maciaszek karol-maciaszek commented Nov 26, 2019 •
edited
Loading

Closes #852

Checklist

  • Tests have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?

Bug fix

Does this PR introduce a breaking change?

No

Screenshots

Screen Shot 2019-11-26 at 16 22 12

Screen Shot 2019-11-26 at 16 23 17

@karol-maciaszek karol-maciaszek changed the title fix: parsing url encoded body for runtime expressions Parsing URL-Encoded body for runtime expressions Nov 26, 2019
XVincentX
XVincentX approved these changes Nov 28, 2019
View reviewed changes
Copy link
Contributor

@XVincentX XVincentX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not that bad. The additional code gets executed only if a callback is invoked and the response. I get that it is not ideal, but I think it's still decent.

I'll add a comment and a changeling line, merge and release 3.1.1

packages/http/src/mocker/index.ts Show resolved Hide resolved
@XVincentX XVincentX merged commit 0d1152c into master Nov 28, 2019
@XVincentX XVincentX deleted the fix/url-encoded-duck-tape branch November 28, 2019 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XVincentX XVincentX XVincentX approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prism callbacks are not working when payload is not application/json
2 participants
@karol-maciaszek @XVincentX