feat: handle allowedParams #828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XVincentX
force-pushed
the
feat/messages
branch
from
eddd7e4
to
8a83b07
Compare
XVincentX
force-pushed
the
feat/messages
branch
from
8a83b07
to
2ba9889
Compare
XVincentX
force-pushed
the
feat/messages
branch
from
ed302b4
to
99bb042
Compare
karol-maciaszek
approved these changes
Nov 19, 2019
| severity, | ||
| })); | ||
| return errors.map<IPrismDiagnostic & { path: Segment[] }>(error => { | ||
| const allowedParameters = 'allowedValues' in error.params ? `: ${error.params.allowedValues.join(', ')}` : ''; |
There was a problem hiding this comment.
Seems that allowedValues is set only when dealing with enum 👍 https://github.com/epoberezkin/ajv/search?q=allowedValues&unscoped_q=allowedValues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to handle the
allowedValuesin theparamsobject (if present) to print better messages.