feat: file support for harness #720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XVincentX
force-pushed
the
feat/harness-file-support
branch
from
a80139c
to
b40db35
Compare
XVincentX
requested review from
lag-of-death,
karol-maciaszek and
philsturgeon
XVincentX
force-pushed
the
feat/harness-file-support
branch
from
b40db35
to
440c6a1
Compare
Co-Authored-By: Karol Maciaszek <[email protected]>
lag-of-death
approved these changes
Oct 21, 2019
karol-maciaszek
suggested changes
Oct 21, 2019
XVincentX
force-pushed
the
feat/harness-file-support
branch
from
914f206
to
88c44c8
Compare
|
Nice to see comments that otherwise wouldn't have popped up from the gigantic PR by the way :) |
XVincentX
force-pushed
the
feat/harness-file-support
branch
from
88c44c8
to
5f80046
Compare
Co-Authored-By: Karol Maciaszek <[email protected]>
XVincentX
force-pushed
the
feat/harness-file-support
branch
from
5f80046
to
503e6d7
Compare
|
@XVincentX changelog line is missing |
|
It was on purpose, since we do not want to document internal changes that do not affect the users (library updates and shit). However this might affect users writing tests. Adding a line. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been back ported from #669
By merging this in master the diff of the Proxy PR shall become significantly smaller and help people get that 馃悏 over the finish line.