fix: type import rewrite #701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XVincentX
force-pushed
the
feat/transform
branch
from
85320c0
to
deca8cd
Compare
karol-maciaszek
approved these changes
Oct 14, 2019
| "tsconfig-paths": "^3.8.0", | ||
| "ttypescript": "^1.5.7", |
There was a problem hiding this comment.
I hope we'll get rid of it when typescript starts supporting plugins via config.
There was a problem hiding this comment.
This is not happening anytime soon unfortunately :(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is kind of a nasty TS to JS bug I found while trying to use Prism for its hosted version
Fundamentally given that it is a monorepo when generating the types for the current project the references points to the source code:
It goes without saying that such path does not exist in the published package, since that is instead found in
@stoplight/prism-corepackage.If you're using JavaScript, you won't even notice this bug. However, if you're using TypeScript and the
httppackage, you'll notice some functions will returnanyinstead of the correct interface (because TypeScript can't find the types, it will assumeany).This PR will use
ttypescriptproject (a declarative wrapper for the TS compiler API) and adding a dropbox developed plugin that will rewrite the generated files path correctly