-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: validating output status code #648
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Some questions, a proposal and a doubt, but we're almost there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code is good. I'm not approving because you said you want to try to convert this into an Option — let me know if you need help or you want to defer the task and I'll approve right away.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've put some comments and suggestions on how to make this a little bit easier to reason about but good job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm pre-approving. We need @philsturgeon to answer our question and then I'll leave the merge to you so you can check out the changes I did to make TypeScript happy again.
Closes #647
Checklist
What kind of change does this PR introduce?
Bugfix
What is the current behavior? What is the new behavior?
Response's status code is not validated against responses found in the spec.
Does this PR introduce a breaking change?
No (we do not have proxy functionality yet, right?)