-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: killing subprocess only if prism is running in multiprocess mode #645
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's OK when the changelog is adjusted 👍
hm.. just curious if we could do sth like:
in an e2e test? maybe the change could be tested like this? WDYT @StefanDywersant ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments, good to go. I'll leave the merge to you.
I doubt whether I can match log lines here. I also can't start two prism instances here in order to reproduce the error. |
Closes #644
Checklist
What kind of change does this PR introduce?
Bug fix
What is the current behavior? What is the new behavior?
Cli is trying to kill subprocess even if it is not running in multi-process mode. It results in no nice-looking line
✖ fatal Cannot read property 'kill' of undefined
.This fix moves logging of errors to the place where the context (single/multiprocess) is known.
.kill
will be invoked only in the latter context.Does this PR introduce a breaking change?
No