Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2305 document Node 18.16-or-later requirement #2314

Merged
merged 1 commit into from
Jun 23, 2023
Merged

2305 document Node 18.16-or-later requirement #2314

merged 1 commit into from
Jun 23, 2023

Conversation

EdVinyard
Copy link
Contributor

Addresses #2305

Summary

Prism requires NodeJS 18.16 or later due to an upstream bug in undici in NodeJS 18.15 (and possibly earlier).

Checklist

  • The basics
    • I tested these changes manually in my local or dev environment
  • Tests
    • Added or updated
    • N/A
  • Event Tracking
    • I added event tracking and followed the event tracking guidelines
    • N/A
  • Error Reporting
    • I reported errors and followed the error reporting guidelines
    • N/A

Screenshots
N/A

Additional context
N/A

@EdVinyard EdVinyard requested a review from a team as a code owner June 22, 2023 16:33
@EdVinyard EdVinyard requested review from brendarearden and RaySalty and removed request for a team June 22, 2023 16:33
@EdVinyard EdVinyard mentioned this pull request Jun 22, 2023
Closed
RaySalty
RaySalty approved these changes Jun 22, 2023
View reviewed changes
Copy link
Contributor

@RaySalty RaySalty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me!

@chohmann chohmann merged commit b6bdcb4 into master Jun 23, 2023
@chohmann chohmann deleted the 2305-document-node-18-requirement branch June 23, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaySalty RaySalty RaySalty approved these changes

@brendarearden brendarearden brendarearden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@EdVinyard @brendarearden @RaySalty @chohmann