Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make x-json-schema-faker work more sensibly #2181

Merged
merged 4 commits into from
Nov 29, 2022
Merged

Conversation

daniel-white
Copy link

@daniel-white daniel-white commented Nov 28, 2022

@daniel-white daniel-white marked this pull request as ready for review November 28, 2022 21:20
@daniel-white daniel-white requested a review from a team as a code owner November 28, 2022 21:20
@daniel-white daniel-white requested review from chohmann and removed request for a team November 28, 2022 21:20

export async function configureExtensionsFromSpec(specFilePathOrObject: string | object): Promise<void> {
const result = decycle(await dereference(specFilePathOrObject));
const result = decycle(await new $RefParser().dereference(specFilePathOrObject));
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i was getting some weird module problems with the static method :(

Copy link
Contributor

@chohmann chohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@daniel-white daniel-white changed the title make x-json-schema-faker work more sensibily make x-json-schema-faker work more sensibly Nov 29, 2022
@daniel-white daniel-white merged commit 738866e into master Nov 29, 2022
@daniel-white daniel-white deleted the chore/jsf-investigate branch November 29, 2022 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants