fix: remove deprecated usage of parse

[jbl428]

Summary

Replace depreacted parse function to WHATWG URL.

Checklist

• The basics
  • I tested these changes manually in my local or dev environment
• Tests
  • Added or updated
  • N/A
• Event Tracking
  • I added event tracking and followed the event tracking guidelines
  • N/A
• Error Reporting
  • I reported errors and followed the error reporting guidelines
  • N/A

[Nezteb]

FYI @chohmann I added TC as a reviewer and removed @Amjcraft. This PR is old/stale, so I just wanted to make sure it's on your radar! (Aaron: If you still are willing/able to review this, feel free!)

[daniel-white]

why was this moved into the inner scopes?

[jbl428]

I thought that previous mock's call history should be cleared before each describe started .

If second describe pass, the third one always pass because both have same test body.

      describe('when calling a method with overridden url', () => {
        beforeAll(() => client.get('/pet', { baseUrl: 'https://www.google.it' }));

        afterAll(() => jest.clearAllMocks());

        test('should call the mocker with the replaced full url', () => {
          expect(mock.default).toBeCalledWith({ // <-- same body
            resource: expect.anything(),
            input: expect.objectContaining({
              data: expect.objectContaining({
                url: expect.objectContaining({
                  baseUrl: 'https://www.google.it',
                  path: '/pet',
                }),
              }),
            }),
            config: expect.anything(),
          });
        });
      });

      describe('when calling a method with a full url', () => {
        beforeAll(() => client.get('https://www.google.it/pet'));

        afterAll(() => jest.clearAllMocks());

        test('should call the mocker with the replaced full url', () => {
          expect(mock.default).toBeCalledWith({  // <-- same body
            resource: expect.anything(),
            input: expect.objectContaining({
              data: expect.objectContaining({
                url: expect.objectContaining({
                  baseUrl: 'https://www.google.it',
                  path: '/pet',
                }),
              }),
            }),
            config: expect.anything(),
          });
        });
      });
    })

[daniel-white]

is search guaranteed not to be undefined?

[jbl428]

Yes, I found that it is always string even though there are no query string in URL.
but I think it is better to make code more defensive 😄

[daniel-white]

i'm not seeing any functional changes here

[jbl428]

It is my mistake :)

[daniel-white]

why include this if is already spread in from line 46?

[jbl428]

Since partialUrl.host is a getter not property. It is not copied properly.

Come to think of it, it would be better to use Object.assign instead of spread. :)

[chohmann]

The code looks good! Can you resolve the docs conflicts? We'll be good to go then!