-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Plug leak #1890
[WIP] Plug leak #1890
Conversation
acde342
to
ae81d91
Compare
packages/cli/src/operations.ts
Outdated
if (isOpenAPI2(result)) operations = transformOas2Operations(result); | ||
else if (isOpenAPI3(result)) operations = transformOas3Operations(result); | ||
else if (isPostmanCollection(result)) operations = transformPostmanCollectionOperations(result); | ||
else throw new Error('Unsupported document format'); | ||
|
||
operations.forEach((op, i, ops) => { | ||
if (op.request !== undefined) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I see your point, make sense
@radzserg Hmmm. I've been sidetracked by another topic and thus haven't had the time to fix all the tests. I've still got some work in that area. However, even if the CI doesn't pass, you might be willing to take an early peek at this WIP. Feedback would be very welcome ;-) |
Superceded by #1892 |
Closing due to fix: #1892 |
Fixes #1881
Summary
Replace this with something that explains what this PR is for and why it matters.
Checklist
Screenshots
If applicable, add screenshots or gifs to help demonstrate the changes. If not applicable, remove this screenshots
section before creating the PR.
Additional context
Add any other context about the pull request here. Remove this section if there is no additional context.