Teach matchPath to honor fragments containing both concrete and templated parts #1876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will ensure only linefeeds are staged while making Prettier nicer to Windows contributors
nulltoken
requested review from
a team and
chohmann
and removed request for
a team
nulltoken
force-pushed
the
ntk/matcher_fix
branch
from
c95f18b
to
86115bd
Compare
nulltoken
changed the title
nulltoken
force-pushed
the
ntk/matcher_fix
branch
3 times, most recently
from
48bf069
to
43d8ca0
Compare
…ated parts
Previous implementation was ignoring concrete parts of path segments
while trying to match requests to potential operations: the matcher was
wrongly thinking `/something` was a good fit for `/something.{format}`.
nulltoken
force-pushed
the
ntk/matcher_fix
branch
from
43d8ca0
to
fa8b637
Compare
nulltoken
changed the title
|
@chohmann 👋 No longer a WIP and ready for review. |
Windows 😳 ... I won't hold it against you 😉 |
chohmann
approved these changes
Aug 26, 2021
|
@nulltoken this was included in Prism v4.3.4 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previous implementation was ignoring concrete parts of path segments while trying to match requests to potential operations: the matcher was wrongly thinking
/somethingwas a good fit for/somethingelse.{format}.This proposal fixes this.
This PR also includes a commit to make Windows contributors' life a bit easier by keeping Prettier endlines check at bay, while ensuring no
CRwill ever be staged in the git repository.Checklist