Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace date-time validator with our bug fixed version #1856

Merged
merged 4 commits into from
Jul 16, 2021

Conversation

chohmann
Copy link
Contributor

Addresses #1830

Summary

Replaces the date-time validator provided by ajv-formats with the original functionality + our bug fix from ajv-validator/ajv-formats#33.

Based on the conversation on ajv-validator/ajv-formats#33 this bug fix won't be accepted into ajv-formats for awhile, if at all.

Checklist

  • The basics
    • I tested these changes manually in my local or dev environment
  • Tests
    • Added or updated
    • N/A
  • Event Tracking
    • I added event tracking and followed the event tracking guidelines
    • N/A
  • Error Reporting
    • I reported errors and followed the error reporting guidelines
    • N/A

@chohmann chohmann requested review from a team, rainum and P0lip and removed request for a team July 15, 2021 20:50
Copy link
Contributor

@rainum rainum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🚀 I'm glad that this issue if finally resolved

@chohmann chohmann merged commit 44186db into master Jul 16, 2021
@chohmann chohmann deleted the fix/date-time-format-validation branch July 16, 2021 16:09
This was referenced Apr 29, 2024
This was referenced Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants