Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly lookup the properties in lowercase #1268

Merged
merged 9 commits into from
Jul 1, 2020
Merged

Correctly lookup the properties in lowercase #1268

merged 9 commits into from
Jul 1, 2020

Conversation

XVincentX
Copy link
Contributor

@XVincentX XVincentX commented Jun 30, 2020 •
edited
Loading

Closes #1267

  • Correctly lookup properties in lower case (this happens because query string and headers are case insensitive)
  • Make the createJsonSchema function pure
  • Auto publishes the master branch under the beta tag automagically

@XVincentX XVincentX added this to the 2020-06-24 milestone Jun 30, 2020
@XVincentX XVincentX self-assigned this Jun 30, 2020
@XVincentX XVincentX added the team/platinum-falcons Team Platinum Falcons label Jul 1, 2020
karol-maciaszek
karol-maciaszek approved these changes Jul 1, 2020
View reviewed changes
Copy link
Contributor

@karol-maciaszek karol-maciaszek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for little typo and naming suggestion.

CHANGELOG.md Outdated Show resolved Hide resolved
packages/http/src/validator/validators/params.ts Outdated Show resolved Hide resolved
XVincentX and others added 2 commits July 1, 2020 11:01
@XVincentX XVincentX merged commit e5aa564 into master Jul 1, 2020
@XVincentX XVincentX deleted the fix/lowercase branch July 1, 2020 16:04
XVincentX added a commit that referenced this pull request Jul 8, 2020
@XVincentX @karol-maciaszek
Correctly lookup the properties in lowercase (#1268)
9eacb1f 
* do not loweracse

* make createJsonSchemaFromParams pure

* lowercase on property lookup in the schema

* add harness

* changelog: add line

* auto get the correct version

* release beta

* Update CHANGELOG.md

Co-authored-by: Karol Maciaszek <[email protected]>

* Update packages/http/src/validator/validators/params.ts

Co-authored-by: Karol Maciaszek <[email protected]>

Co-authored-by: Karol Maciaszek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karol-maciaszek karol-maciaszek karol-maciaszek approved these changes

Assignees

@XVincentX XVincentX

Labels
team/platinum-falcons Team Platinum Falcons
Projects
None yet
Milestone
2020-06-24
Development

Successfully merging this pull request may close these issues.

Uppercase string in filter[] query parameter causes unhandled exception when attempting to call mocked API
2 participants
@XVincentX @karol-maciaszek