Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: properly declare all the dependencies #1072

Merged
merged 2 commits into from
Apr 1, 2020
Merged

fix: properly declare all the dependencies #1072

merged 2 commits into from
Apr 1, 2020

Conversation

XVincentX
Copy link
Contributor

@XVincentX XVincentX commented Mar 31, 2020

Explicitly declare the dependencies of the packages instead of relying on the module resolution

Copy link
Contributor

@marcelltoth marcelltoth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What problem does this solve?

Aren't we creating redundancies / possible version duplications?

@XVincentX
Copy link
Contributor Author

Nope, we're actually making sure that if I install only prism-core for some reason I get all its dependencies necessary to run. If now you install it and try to require it you'll get an error because fp-ts (direct dependency) isn't present.

Copy link
Contributor

@marcelltoth marcelltoth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't checked them all whether these are the actual deps, but I trust you on that.

@XVincentX
Copy link
Contributor Author

I used an eslint plugin to detect them so the list was kind of automatically generated.

@XVincentX XVincentX merged commit a2f04d5 into master Apr 1, 2020
@XVincentX XVincentX deleted the fix/deps branch April 1, 2020 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants